Replace more string fakematches#414
Merged
mattbruv merged 13 commits intobfbbdecomp:mainfrom Feb 24, 2025
Merged
Conversation
mattbruv
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced more
stringBase0s with their actual strings. This also includes a few hex numbers being replaced by their appropriate chars.In some of these files, I took all the strings from the respective .s files and turned them into top-level variables. This makes the later functions have matching stringBase0 offsets without needing to have all the rest of the functions decomped yet (and therefore all the other strings defined yet). These can then later be removed once the files are 100% decomped